fix(ui): support clipboard paste in filter and command inputs#202
Open
nick4eva wants to merge 2 commits into
Open
fix(ui): support clipboard paste in filter and command inputs#202nick4eva wants to merge 2 commits into
nick4eva wants to merge 2 commits into
Conversation
Filter views only routed tea.KeyPressMsg to their textinput, so bracketed paste (Ctrl+Shift+V, tmux paste) was dropped and the textinput's built-in Ctrl+V never received its clipboard-read result. Forward paste and other textinput-bound messages to the focused filter input in the resource browser, service browser, log view, tag search view and multi selector, and accept tea.PasteMsg in command mode.
yimsk
requested changes
Jul 18, 2026
yimsk
left a comment
yimsk
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding paste support and the accompanying tests. Overall, this looks like a good change.
Two things stood out while reviewing it:
- The clipboard result from Ctrl+V does not return to the command input in command mode.
- Mouse-wheel scrolling stops working in LogView while the filter is active.
Could you please take a look at these two cases?
Address review feedback on clawscli#202: - Ctrl+V in command mode never inserted text because bubbles returns the clipboard read as an unexported message type. Add clipboard.Paste, which reads the clipboard and re-enters as a public tea.PasteMsg, and intercept ctrl+v in CommandInput before delegating to the textinput. - Mouse-wheel scrolling stopped working in LogView while the filter was active; mouse messages now bypass the filter fallback to the viewport.
Contributor
Author
|
Thanks for feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter views only routed tea.KeyPressMsg to their textinput, so bracketed paste (Ctrl+Shift+V, tmux paste) was dropped and the textinput's built-in Ctrl+V never received its clipboard-read result.
Forward paste and other textinput-bound messages to the focused filter input in the resource browser, service browser, log view, tag search view and multi selector, and accept tea.PasteMsg in command mode.
Closes #201